Replace execution context controls with record mode controls #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
requested review from
Frizi,
farmaazon,
MichaelMauderer and
vitvakatu
as code owners
kazcw
added
the
CI: No changelog needed
farmaazon
approved these changes
Feb 22, 2024
app/gui2/src/assets/icons.svg
Outdated
Comment on lines
653
to
661
| <symbol id="record" viewBox="0 0 16 16" width="16" height="16" fill="none"> | ||
| <circle cx="8" cy="8" r="7" fill="currentColor" /> | ||
| </symbol> | ||
|
|
||
| <symbol id="record_once" viewBox="0 0 24 16" width="24" height="16" fill="none"> | ||
| <rect x="0" y="1" width="3" height="14" rx="1" fill="currentColor" /> | ||
| <circle cx="12" cy="8" r="7" fill="currentColor" /> | ||
| <rect x="21" y="1" width="3" height="14" rx="1" fill="currentColor" /> | ||
| </symbol> |
There was a problem hiding this comment.
Were they added to figma project? If not, then they will be removed upon next export.
|
Can you share a screenshot of what was previously the design/live mode toggle in the on/off positions? |
Added to description. (The padding is a bit ugly in the Before pics because it's an interim state between moving the project name and this PR). |
|
Looks good! Thank you :) |
|
I modified the record-once icon to be 16x16 because we're using exclusively 16x16 icons. This might not be exactly the icon design we want, but I'm going to merge it to get the code changes in; we can tweak the icon later. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #8673. Stacked on #9132.
Before:
After:
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.